Fullview wrapper Thread last updated on 2004-04-22 01:25:44

Posted by member 90007 on 2004-04-10 12:11:55

What I would really like is a wrapper html file for the fullsize screenshots.

I could even code a quick one (as I'm sure you guys can) if you don't have the time.

What I'm really getting frustrated with is clicking a fullscreen pic while browsing the themes, liking it, then having to hunt down the theme separately based on the name (quick note; I think we have enough themes to have a simple search ;) )

Just something that shows the full pic, a Download link, and a link to the details would be awesome :)

Posted by member 1 on 2004-04-10 15:29:55 link

you lost me on this request.

Search is still coming...site rewrite is still in progress as stated in the other 30 threads on searching.

Posted by member 90007 on 2004-04-14 21:08:34 link

Yeah, sorry, I know about search - lapse of conciousness ;)

Here's an example of my request:

Scenario 1 (the way it is now):

You see a thumbnail of a screenshot you like, you click on it, it opens in the same browser window as a raw PNG (No background, no html, just the pic.

If you want to download that theme, you have to go back, or have chosen details, or find it manually



Scenario 2 (The way I would like):

You see a thumbnail of a screenshot you like, you click on it, it opens in (the same browser window, or another - not important) as a centred PNG on a background (same as the site background, perhaps, maybe just black or white), and below the PNG is 2 links: "Details" and "Download" (more info if you like, such as author)

If you want to download that theme, you just click "Download"



That's all I'm asking for, just 2 links on the fullview, the rest is entirely open :)

Posted by member 1 on 2004-04-14 22:30:38 link

I tried to do something like this earlier to get around a flaw in IE however it broke something and I can't remember what. Will look into it again.

Posted by member 90007 on 2004-04-15 03:08:25 link

If you need some help; let me know - There's no way it should break anything and there is a way to code it so that you only change a couple lines in the existing code

Posted by member 1 on 2004-04-15 11:08:17 link

you don't know how much code you are going to break with that. It is not a simple change because of how often full screen images are used. You don't know where or how certain files may be used so it really isn't just 3 lines of code...

Posted by member 90007 on 2004-04-16 23:58:12 link

It should be since this is a PHP site, and any fullscreen links are created by the same script.

Could do the following:
replace an insert of fullscreen.PNG (or $fullscreen as an example variable) in the current code with "/fullscreen.php?fullscreen" or "/fullscreen.php?$fullscreen" with variable

If you want to make it really lean on the existing code:

/fullscreen.php?pic=$fullscreen&?id=$id
("$fullscreen" and "$id" being substituted with the existing variables)
Since id is already used to call details and the download link, the code for the fullscreen page would be v.simple

And, if there is a function that calls fullscreen other than the ones that are known (and used every day), then it can continue to call the PNG itself, no hassle.

Posted by member 90007 on 2004-04-17 00:02:28 link

Plus, if you wanted my help, I would be willing to get the relavent files off the server, test on my own system, then submit the changes files for approval (2-3 I'm expecting for regular user interface since I have no idea what the admins see)
Note: Would just be a transfer from person to person, not from the site itself - I know I shouldn't be trusted with that since I'm not known yet

Posted by member 1 on 2004-04-17 02:08:38 link

Its not that easy because of all the places that the wrapper would need to be used. You don't know how fullscreen.php will effect the modules section of this site...or the themes section...or any of the admin scripts that run. This is a large site written from scratch that can't have things plopped in here or there.

Also...you will notice that there is only one php file for this site...index.php...and it will stay that way. So again...this change will effect more than you could/would/will ever know.

Posted by member 90007 on 2004-04-20 12:19:00 link

Ok, I understand the mentality I'm up against, and I think that's evident to anyone who views this thread.

I don't understand the condescending tone that I'm receiving.
I can see that the site was coded from scratch, and I totally respect that, which is why I gave an approach that barely touched anything.
As I mentioned: any code that didn't know "fullscreen.php (fully able to be implemented in index.php as a function/section) would not be affected: It would simply call the graphic file itself.

I'm not proposing a new structure, nor a massive change, just a little page that is called by one part of one (or 2) function(s).

Posted by member 424 on 2004-04-20 13:16:13 link

we'll add to the todo list, case closed :-p

Posted by member 90007 on 2004-04-21 02:36:32 link

LoL. Fine by me ;)

I'll drop it if someone agrees with me that it's a convenient idea.. Maybe in next rev of the sitecode? :)

Posted by member 12025 on 2004-04-21 08:02:43 link

Just wait a bit and try again.
DeViLbOi seems a bit grouchy lately :).
I'd at least wait to argue about it once the current list of needs is complete (searches, basically).

Posted by member 1 on 2004-04-21 12:22:59 link

none of you seem to want to listen. its not a problem based on me not wanting it...me not letting it happen...or it actually being coded somewhere already. it has everything to do with the 99% chance that it won't happen because we have problems integrating it everywhere in the site. fullscreen.php may work just fine as a linked file...however we don't do that here. for security reasons everything is contained within a file so it gives no clue as to what is actually going on. it also provides great security for those trying to get around our security measures. now if you will let it go before you really piss me off for pushing an issue miles past its need I can get back to work.

Posted by member 90007 on 2004-04-22 01:25:44 link

I agree that the disagreement itself has become larger than the issue, and I am perfectly willing to drop it as requested.

The only problem I have is that I don't seem to be communicating properly because the problems you have with my idea are not problems at all.

1: It will break code - This is a special function that would only be called by other functions that had been specifically modified to do so: All the other code need not know about it.

2: Only one file can be in use so no "fullview.php" - The code is easily implementable into the index.php as any available "section" or subsection.

Example of section:
http://www.litestep.net/index.php?section=99&pic=$fullscreen&id=$id


Example of subsection:
http://www.litestep.net/index.php?section=2&action=fullview&pic=$pic&id=$id



Now, I certainly do respect any descisions made, and I have no problem dropping the issue as long as I am fully understood, which at this point apparently I have not been.

Thank you for the work you put into this site, it's not like I'm paying for membership - I'm just trying to contribute :)